Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build #5403

Merged
merged 1 commit into from Jul 16, 2018
Merged

Fix the build #5403

merged 1 commit into from Jul 16, 2018

Conversation

mistercrunch
Copy link
Member

The travis build has been failing for 2 reasons recently

  • pylint takes > 10 minutes without outputing
  • bad merge confict auto resolve in controls.jsx

The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx
@codecov-io
Copy link

Codecov Report

Merging #5403 into master will decrease coverage by 15.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5403       +/-   ##
===========================================
- Coverage   77.15%   61.38%   -15.77%     
===========================================
  Files          44      373      +329     
  Lines        8892    23522    +14630     
  Branches        0     2725     +2725     
===========================================
+ Hits         6861    14440     +7579     
- Misses       2031     9069     +7038     
- Partials        0       13       +13
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 47.32% <ø> (ø)
...c/dashboard/deprecated/v1/components/Dashboard.jsx 0% <0%> (ø)
...ts/src/messageToasts/containers/ToastPresenter.jsx 100% <0%> (ø)
...set/assets/src/SqlLab/components/ColumnElement.jsx 100% <0%> (ø)
...erset/assets/src/explore/actions/exploreActions.js 69.23% <0%> (ø)
...ashboard/components/gridComponents/ChartHolder.jsx 93.18% <0%> (ø)
.../assets/src/visualizations/parallel_coordinates.js 26.31% <0%> (ø)
...et/assets/src/explore/components/controls/index.js 100% <0%> (ø)
...c/dashboard/deprecated/v1/components/CodeModal.jsx 0% <0%> (ø)
...set/assets/src/dashboard/actions/dashboardState.js 41.98% <0%> (ø)
... and 320 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b7c2d...e09823b. Read the comment docs.


[tox]
envlist =
eslint
flake8
javascript
pylint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed? pylint is a valid environment, i.e., tox -e pylint.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I thought I was removing a dependency, will re-add

JamshedRahman pushed a commit to tc-dc/superset that referenced this pull request Jul 18, 2018
The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx
mistercrunch pushed a commit that referenced this pull request Jul 26, 2018
* Visualization Unicode bug fix

* Fix the build (#5403)

The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx

* Visualization Unicode bug fix
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Visualization Unicode bug fix

* Fix the build (apache#5403)

The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx

* Visualization Unicode bug fix
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants