Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[big_number] tooltip shows in the wrong place #5404

Merged
merged 1 commit into from Jul 16, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 16, 2018

@codecov-io
Copy link

codecov-io commented Jul 16, 2018

Codecov Report

Merging #5404 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5404      +/-   ##
==========================================
+ Coverage   61.34%   61.38%   +0.04%     
==========================================
  Files         373      373              
  Lines       23521    23521              
  Branches     2725     2725              
==========================================
+ Hits        14429    14439      +10     
+ Misses       9079     9069      -10     
  Partials       13       13
Impacted Files Coverage Δ
superset/assets/src/visualizations/big_number.js 8.24% <0%> (ø) ⬆️
superset/connectors/sqla/models.py 78.13% <0%> (+0.79%) ⬆️
superset/db_engine_specs.py 53.83% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd47587...f85b80f. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gogogo

@mistercrunch mistercrunch merged commit 48317fd into apache:master Jul 16, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] big number with trend line's tooltip renders in the upper left of the page
3 participants