Added India in country map visualisation. #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
visshaljagtap
commented
Jul 22, 2018
visshaljagtap
commented
- Added option to select "India".
- Added india.geojson upto state level.
|
|
|
@mistercrunch can you please review the changes? |
|
LGTM, though it looks like you forked a broken build, |
|
Sure, thanks @mistercrunch |
- Added option to select "India". - Added india.geojson upto state level.
visshaljagtap
force-pushed
the
india-country-map
branch
from
96b9287
to
b6915a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #5459 +/- ##
=======================================
Coverage 59.11% 59.11%
=======================================
Files 372 372
Lines 23751 23751
Branches 2758 2758
=======================================
Hits 14041 14041
Misses 9695 9695
Partials 15 15
Continue to review full report at Codecov.
|
|
@mistercrunch I have rebased the branch. Please check! |
|
@mistercrunch please merge to master when you get chance :-) |
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
- Added option to select "India". - Added india.geojson upto state level.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.