Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqllab] fix unexpected keyword argument 'ignore_nan' #5490

Merged
merged 1 commit into from Jul 26, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 26, 2018

fixes issue introduced by #5413
@john-bodley @timifasubaa

@codecov-io
Copy link

Codecov Report

Merging #5490 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5490   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files         349      349           
  Lines       22099    22099           
  Branches     2455     2455           
=======================================
  Hits        13996    13996           
  Misses       8089     8089           
  Partials       14       14
Impacted Files Coverage Δ
superset/sql_lab.py 71.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df82d9...f23b313. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to standardize on always using simplejson instead of json, I noticed we use both. The former also has the advantage that it produces strict JSON compared to the latter.

@mistercrunch mistercrunch merged commit 6f87552 into apache:master Jul 26, 2018
@mistercrunch mistercrunch deleted the fixes branch July 26, 2018 22:20
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 26, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
john-bodley pushed a commit to john-bodley/superset that referenced this pull request Sep 14, 2018
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Sep 14, 2018
[sqllab] fix unexpected keyword argument 'ignore_nan' (apache#5490)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants