Remove js packages that are not referenced in js code #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Actually they're not imported/required anywhere, so maybe they aren't used. |
Codecov Report
@@ Coverage Diff @@
## master #5514 +/- ##
=======================================
Coverage 63.12% 63.12%
=======================================
Files 349 349
Lines 22167 22167
Branches 2462 2462
=======================================
Hits 13992 13992
Misses 8161 8161
Partials 14 14Continue to review full report at Codecov.
|
kristw
changed the title
kristw
force-pushed
the
kristw/remove-packages
branch
from
76b9b0f
to
0f353aa
Compare
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brfs,npm,object.entries,object.keysandobject.valuesare not referenced by any of the javascript file in superset.po2jsonwas only referenced as a command-line tool in README and instructed to install as global (npm install -g). This at most should bedevDependencies, but notdependencies.