[bugfix] time filter on dashboard view #5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5546 +/- ##
==========================================
+ Coverage 63.12% 63.34% +0.22%
==========================================
Files 349 349
Lines 22167 22168 +1
Branches 2462 2462
==========================================
+ Hits 13992 14042 +50
+ Misses 8161 8112 -49
Partials 14 14
Continue to review full report at Codecov.
|
Charts using the old since/until time filtering form_data format would only work in the Explore view, not on the dashboard view. This fixes that.
mistercrunch
force-pushed
the
fix_time_filter
branch
from
49afb18
to
7a8574c
Compare
betodealmeida
approved these changes
Aug 3, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Charts using the old since/until time filtering form_data format would only work in the Explore view, not on the dashboard view. This fixes that.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example charts using the old since/until time filtering form_data format would only work in the Explore view, not on the dashboard view. The form_data was fixed in a db migration, but the examples have not been altered, so loading the examples after the db migration would cause problems.
@betodealmeida