[sql lab] allow EXPlAIN queries #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
explain_plan
branch
from
7978350
to
b4f7d51
Compare
mistercrunch
force-pushed
the
explain_plan
branch
from
b4f7d51
to
81a8cc7
Compare
betodealmeida
approved these changes
Aug 3, 2018
superset/sql_parse.py
Outdated
| return self.sql.strip().upper().startswith('EXPLAIN') | ||
|
|
||
| def is_readonly(self): | ||
| """Pessimestic readonly, 100% sure statement won't mutate anything""" |
There was a problem hiding this comment.
s/Pessimestic/Pessimistic/
Codecov Report
@@ Coverage Diff @@
## master #5558 +/- ##
==========================================
+ Coverage 63.14% 63.26% +0.11%
==========================================
Files 351 351
Lines 22240 22262 +22
Branches 2466 2470 +4
==========================================
+ Hits 14044 14083 +39
+ Misses 8181 8164 -17
Partials 15 15
Continue to review full report at Codecov.
|
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [sql lab] allow EXPlAIN queries closes andialbrecht/sqlparse#421 * typo
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5446
related: andialbrecht/sqlparse#421