Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permissions bug fixes #5559

Merged
merged 1 commit into from Aug 3, 2018

Conversation

timifasubaa
Copy link
Contributor

@timifasubaa timifasubaa commented Aug 3, 2018

This PR fixes a few bugs with the permissions flow.

  1. A typo
  2. Making the name of the methods consistent with the names in the security manager

@michellethomas @graceguo-supercat

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #5559 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5559      +/-   ##
==========================================
+ Coverage   63.18%   63.24%   +0.05%     
==========================================
  Files         351      351              
  Lines       22252    22252              
  Branches     2470     2470              
==========================================
+ Hits        14060    14073      +13     
+ Misses       8177     8164      -13     
  Partials       15       15
Impacted Files Coverage Δ
superset/views/core.py 73.86% <ø> (+0.22%) ⬆️
superset/models/core.py 87.09% <0%> (+0.34%) ⬆️
superset/db_engine_specs.py 54.19% <0%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8014709...aec6844. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 1e15566 into apache:master Aug 3, 2018
timifasubaa added a commit to airbnb/superset-fork that referenced this pull request Aug 3, 2018
(cherry picked from commit 1e15566)
timifasubaa added a commit to airbnb/superset-fork that referenced this pull request Aug 3, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants