Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function since_until_to_time_range #5560

Merged
merged 1 commit into from Aug 3, 2018

Conversation

mistercrunch
Copy link
Member

@betodealmeida I had missed removing this function.

It's taken care of earlier in the pipeline with legacy.update_time_range.

It's taken care of earlier in the pipeline with legacy.update_time_range
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #5560 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5560      +/-   ##
==========================================
- Coverage   63.25%   63.22%   -0.03%     
==========================================
  Files         351      351              
  Lines       22258    22251       -7     
  Branches     2470     2470              
==========================================
- Hits        14079    14068      -11     
- Misses       8164     8168       +4     
  Partials       15       15
Impacted Files Coverage Δ
superset/utils.py 88.88% <ø> (-0.31%) ⬇️
superset/viz.py 79.34% <ø> (-0.02%) ⬇️
superset/models/core.py 86.57% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bd17d...18d6b42. Read the comment docs.

@mistercrunch mistercrunch merged commit 89b7ca0 into apache:master Aug 3, 2018
@mistercrunch mistercrunch deleted the remove_utils_f branch August 3, 2018 22:34
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
It's taken care of earlier in the pipeline with legacy.update_time_range
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants