update python3 version for testing to 3.6 #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octaviancorlade
changed the title
mistercrunch
reviewed
Aug 4, 2018
CONTRIBUTING.md
Outdated
| @@ -65,7 +65,7 @@ meets these guidelines: | |||
| 3. If the pull request adds functionality, the docs should be updated | |||
| as part of the same PR. Doc string are often sufficient, make | |||
| sure to follow the sphinx compatible standards. | |||
| 4. The pull request should work for Python 2.7, and ideally Python 3.4+. | |||
| 4. The pull request should work for Python 2.7, and ideally Python 3.5+. | |||
|
SGTM, we should go full on 3.6 soon. I think it's important for libraries to support a wide array of version, but since Superset is a full on product, people can set it up using 3.6. Maybe we should write a SIP (Superset Improvement Proposal) about it. |
Codecov Report
@@ Coverage Diff @@
## master #5562 +/- ##
=======================================
Coverage 63.23% 63.23%
=======================================
Files 351 351
Lines 22258 22258
Branches 2470 2470
=======================================
Hits 14075 14075
Misses 8168 8168
Partials 15 15Continue to review full report at Codecov.
|
|
Updated, a bit unsure about that plus sign in "Python 3.6+" at this point. |
john-bodley
approved these changes
Aug 6, 2018
rileyshu53
approved these changes
Aug 7, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* update python version for testing to 3.6 * CONTRIBUTING.md states pull requests should work on py27, py36+ * CONTRIBUTING.md states pull requests should work on py27 and py36
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.4 is not supported and since #4835 python 3.6 is used for testing in Travis