[sql lab] visualization flow to detect unaliased columns #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Aug 7, 2018
•
mistercrunch
commented
Codecov Report
@@ Coverage Diff @@
## master #5579 +/- ##
==========================================
+ Coverage 63.58% 63.59% +0.01%
==========================================
Files 358 359 +1
Lines 22742 22802 +60
Branches 2530 2534 +4
==========================================
+ Hits 14461 14502 +41
- Misses 8266 8285 +19
Partials 15 15
Continue to review full report at Codecov.
|
betodealmeida
requested changes
Aug 8, 2018
| @@ -65,6 +81,10 @@ class ExploreResultsButton extends React.PureComponent { | |||
| getQueryDuration() { | |||
| return moment.duration(this.props.query.endDttm - this.props.query.startDttm).asSeconds(); | |||
| } | |||
| getInvalidColumns() { | |||
| const re = /^\w+$/; | |||
There was a problem hiding this comment.
It might be better to use /^[A-Za-z_]\w*/ here, to avoid SELECT COUNT(1) AS 123.
There was a problem hiding this comment.
Good call, added some tests for 'a', '1', '123'.
|
Addressed comments, merging. |
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [sql lab] visualization flow to detect unaliased columns * Addressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.