[table editor] disable 'Sync table metadata' button for Superset views #5580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a bit tricky since there's a bug in react-bootstrap that make it tricky to show a tooltip on a disabled button.
mistercrunch
force-pushed
the
sync_cols_disable
branch
from
e1f2021
to
963d5e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #5580 +/- ##
==========================================
- Coverage 63.58% 63.58% -0.01%
==========================================
Files 358 358
Lines 22742 22747 +5
Branches 2530 2532 +2
==========================================
+ Hits 14461 14464 +3
- Misses 8266 8268 +2
Partials 15 15
Continue to review full report at Codecov.
|
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
apache#5580) This was a bit tricky since there's a bug in react-bootstrap that make it tricky to show a tooltip on a disabled button.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit tricky since there's a bug in react-bootstrap that make
it tricky to show a tooltip on a disabled button.