[fix] Enforcing main dttm column #5584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley-main-dttm-column
branch
3 times, most recently
from
f07b2ba
to
a322ba2
Compare
Codecov Report
@@ Coverage Diff @@
## master #5584 +/- ##
==========================================
- Coverage 63.62% 63.62% -0.01%
==========================================
Files 359 359
Lines 22820 22823 +3
Branches 2533 2534 +1
==========================================
Hits 14520 14520
- Misses 8285 8288 +3
Partials 15 15
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Aug 9, 2018
|
This PR would remedy #3629, I suppose. Thanks a lot! |
| @@ -846,6 +841,12 @@ export const controls = { | |||
| const newState = {}; | |||
| if (state.datasource) { | |||
| newState.options = state.datasource.columns.filter(c => c.is_dttm); | |||
| newState.default = null; | |||
There was a problem hiding this comment.
Not related to your PR: props would be a better variable name than newState in this method.
There was a problem hiding this comment.
@mistercrunch I've renamed newState to props.
|
LGTM |
john-bodley
force-pushed
the
john-bodley-main-dttm-column
branch
from
a322ba2
to
3cf15fa
Compare
john-bodley
force-pushed
the
john-bodley-main-dttm-column
branch
from
3cf15fa
to
4160819
Compare
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Aug 13, 2018
(cherry picked from commit 2685ab4)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that if defined the "Main Datetime Column" is used as the default value. Previously this value was being ignored and thus for datasource with multiple temporal columns a sub-optimal choice may occur, i.e., using a non-partitioned column.
to: @GabeLoins @graceguo-supercat @michellethomas @mistercrunch @williaster
closes #3629