Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashobard] Fix bad merge #5624

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

graceguo-supercat
Copy link

Fixing a bad code merge in dashboard save function 😖

@mistercrunch
Copy link
Member

LGTM

@codecov-io
Copy link

Codecov Report

Merging #5624 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5624      +/-   ##
==========================================
- Coverage   63.48%   63.48%   -0.01%     
==========================================
  Files         360      360              
  Lines       22889    22888       -1     
  Branches     2547     2547              
==========================================
- Hits        14531    14530       -1     
  Misses       8343     8343              
  Partials       15       15
Impacted Files Coverage Δ
superset/views/core.py 73.97% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763eeca...f0b0d51. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 9f6ac08 into apache:master Aug 14, 2018
@graceguo-supercat graceguo-supercat deleted the gg-FixBadMerge branch August 14, 2018 17:57
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Aug 14, 2018
(cherry picked from commit 9f6ac08)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants