[bubble] Fixing ad-hoc metric labels #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5630 +/- ##
==========================================
+ Coverage 63.44% 63.49% +0.04%
==========================================
Files 360 360
Lines 22890 22890
Branches 2548 2551 +3
==========================================
+ Hits 14523 14533 +10
+ Misses 8352 8342 -10
Partials 15 15
Continue to review full report at Codecov.
|
conglei
reviewed
Aug 14, 2018
conglei
reviewed
Aug 14, 2018
| s += row(fd.x, formatter(p.x)); | ||
| s += row(fd.y, formatter(p.y)); | ||
| s += row(fd.size, formatter(p.size)); | ||
| s += row(fd.x.label, formatter(p.x)); |
There was a problem hiding this comment.
What about non ad-hoc metric field? seems like we should first test if fd.x is an object or it is just a string. Same thing for the other two.
There was a problem hiding this comment.
@conglei only ad-hoc metrics are defined for bubble-charts.
john-bodley
force-pushed
the
john-bodley-bubble-adhoc-metrics
branch
from
362dd09
to
d455983
Compare
|
@conglei thanks for bringing this to my attention. I've updated the logic. |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Aug 15, 2018
(cherry picked from commit 46f89f4)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bubble chart labels which previously rendered as
[object Object]if the metric was an ad-hoc metric.to: @GabeLoins @graceguo-supercat @michellethomas @mistercrunch @timifasubaa