[bug fix] Fixed forced percentage format on tooltips and bubble chart tooltips format. #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubble chart tooltip format
michellethomas
approved these changes
Aug 14, 2018
|
It looks like something pylint had a stalled build in travis, you may want to try to kick off another build to get it to pass. Otherwise lgtm |
Codecov Report
@@ Coverage Diff @@
## master #5631 +/- ##
==========================================
- Coverage 63.49% 63.49% -0.01%
==========================================
Files 360 360
Lines 22889 22890 +1
Branches 2548 2548
==========================================
Hits 14533 14533
- Misses 8341 8342 +1
Partials 15 15
Continue to review full report at Codecov.
|
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Aug 15, 2018
… tooltips format. (apache#5631) * fixed forced percentage format on tooltip and correct reflection on bubble chart tooltip format * re-trigger build (cherry picked from commit 2171ffb)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
… tooltips format. (apache#5631) * fixed forced percentage format on tooltip and correct reflection on bubble chart tooltip format * re-trigger build
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1: For line charts, when the y-axis is force to set as percentage (hen computing a "Percentage" or "Contribution" selected, we force a percentage format), the tooltip is not correctly reflected on this change.
Before:
After:
Bug 2: For bubble chart, the format of tooltip is not correct reflect on the x and y tick formats.
Before:
After:
cc: @john-bodley @michellethomas @williaster