[viz flow] detect TIMESTAMP, transition to line chart #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5634 +/- ##
==========================================
+ Coverage 63.44% 63.45% +0.01%
==========================================
Files 360 360
Lines 22953 22958 +5
Branches 2558 2557 -1
==========================================
+ Hits 14562 14568 +6
+ Misses 8376 8375 -1
Partials 15 15
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Aug 16, 2018
superset/dataframe.py
Outdated
| is_date = False | ||
| if col_db_type: | ||
| is_date = self.is_date(self.df.dtypes[col]) or any([ | ||
| col_db_type.lower().startswith(s) for s in ('time', 'data') |
There was a problem hiding this comment.
Should we move this extra logic to the is_date method? Eg:
def is_date(self, dtypes, col_db_type=None):
if col_db_type and any(col_db_type.lower().startswith(s) for s in ('time', 'data')):
return True
...
is_date = self.is_date(self.df.dtypes[col], col_db_type.lower())
mistercrunch
force-pushed
the
fix_timestamp
branch
from
02ecdfc
to
0e44da6
Compare
mistercrunch
force-pushed
the
fix_timestamp
branch
from
0e44da6
to
e014717
Compare
|
Good call, refactored all this. |
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [viz flow] detect TIMESTAMP, transition to line chart * Refactor is_date
15 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.