Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore View Perf Fix #5637

Merged

Conversation

sumedhsakdeo
Copy link
Contributor

Fixes the big query performance issue from the Explore View in superset. Similar to the one we solve for sqllab with #5632

@codecov-io
Copy link

Codecov Report

Merging #5637 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5637      +/-   ##
==========================================
- Coverage   63.51%   63.51%   -0.01%     
==========================================
  Files         360      360              
  Lines       22888    22890       +2     
  Branches     2549     2549              
==========================================
+ Hits        14538    14539       +1     
- Misses       8335     8336       +1     
  Partials       15       15
Impacted Files Coverage Δ
superset/db_engine_specs.py 54.3% <75%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0afef...ea9b28d. Read the comment docs.

@mistercrunch mistercrunch merged commit 5966a67 into apache:master Aug 15, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 21, 2018
(cherry picked from commit 5966a67)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Aug 22, 2018
(cherry picked from commit 5966a67)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Aug 22, 2018
(cherry picked from commit 5966a67)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants