Field names in big query can contain only alphanumeric and underscore #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5641 +/- ##
==========================================
- Coverage 63.49% 63.49% -0.01%
==========================================
Files 360 360
Lines 22914 22926 +12
Branches 2551 2551
==========================================
+ Hits 14550 14556 +6
- Misses 8349 8355 +6
Partials 15 15
Continue to review full report at Codecov.
|
|
As per your recommendation @mistercrunch found a better place for mutating label. PTAL |
|
@sumedhsakdeo you have linting errors on the line that's very long |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
…apache#5641) * Field names in big query can contain only alphanumeric and underscore * bad quote * better place for mutating labels * lint * bug fix thanks to mistercrunch * lint * lint again (cherry picked from commit 80e7778)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
…apache#5641) * Field names in big query can contain only alphanumeric and underscore * bad quote * better place for mutating labels * lint * bug fix thanks to mistercrunch * lint * lint again (cherry picked from commit 80e7778)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…apache#5641) * Field names in big query can contain only alphanumeric and underscore * bad quote * better place for mutating labels * lint * bug fix thanks to mistercrunch * lint * lint again
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to use explore view to plot charts against a BigQuery dataset, superset was used some characters in the field name which BigQuery syntax did not like.
Here, is the error returned by BigQuery
Invalid field name "AVG(lat)". Fields must contain only letters, numbers, and underscores, start with a letter or underscore, and be at most 128 characters longThis PR, fixes this issue so that we can plot charts against big query dataset.