Filter out null locations by default #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5642 +/- ##
==========================================
- Coverage 63.51% 63.51% -0.01%
==========================================
Files 360 360
Lines 22890 22902 +12
Branches 2549 2549
==========================================
+ Hits 14539 14546 +7
- Misses 8336 8341 +5
Partials 15 15
Continue to review full report at Codecov.
|
hughhhh
reviewed
Aug 18, 2018
superset/viz.py
Outdated
|
|
||
| # add NULL filters | ||
| if fd.get('filter_nulls'): | ||
| spatial_columns = set() |
There was a problem hiding this comment.
Can we get a unit test around this block? Just making sure fd has the proper values
|
🚢 |
hughhhh
approved these changes
Aug 19, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
* Filter out null locations by default * Move exception to better place * Add unit test * Return columns in order for test and readibility (cherry picked from commit 4c5142d)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* Filter out null locations by default * Move exception to better place * Add unit test * Return columns in order for test and readibility (cherry picked from commit 4c5142d)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* Filter out null locations by default * Move exception to better place * Add unit test * Return columns in order for test and readibility (cherry picked from commit 4c5142d)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Filter out null locations by default * Move exception to better place * Add unit test * Return columns in order for test and readibility
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a checkbox to all spatial visualizations allowing null locations to be filtered out by default. Currently, they are shown as
0, 0, which is confusing.My original approach to solving this was by filtering the data on
viz.py, but at that point we don't know if a zero is a valid location or not (Druid return zeros for null, IIRC). Adding the extra filters to the form data has the benefit that the data is filtered in the database, and in a consistent way.Here's how the
flightsdataset currently looks like — note all the arcs with an edge at the Equator/Greenwich:When we toggle "Ignore null locations" they are removed: