Minor improvements to SQL Lab UI #5662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5662 +/- ##
=========================================
+ Coverage 63.49% 63.5% +<.01%
=========================================
Files 360 360
Lines 22889 22891 +2
Branches 2549 2551 +2
=========================================
+ Hits 14534 14536 +2
Misses 8340 8340
Partials 15 15
Continue to review full report at Codecov.
|
|
These look great! 🙌 I'll 👀 more closely, my only high-level thought for now is about the "See table Schema" change. I thiiiink if you don't add a table, you can't actually query it in the SQL lab editor which is why it was labeled "add table". If that's true I wonder if "add table to workspace" or something would be a better label? Just a thought. |
|
I can query without adding a table. Only
|
|
ah got it 👍 (sorry I should have just checked that before flagging) |
|
Thank you. Can merge when you see fit. |
* Remove "for" * add space * Separate control to select table from database and schema. * Adjust schema displays * Fix caret and arrow position in Select and Tab * Reduce space after caret in tab header * Use translator * Align icons in the pop-up menu in Sql Lab * Add new table in front of the list (so it will appear on top) * shorten message * reduce line (cherry picked from commit cdd348a)
* Remove "for" * add space * Separate control to select table from database and schema. * Adjust schema displays * Fix caret and arrow position in Select and Tab * Reduce space after caret in tab header * Use translator * Align icons in the pop-up menu in Sql Lab * Add new table in front of the list (so it will appear on top) * shorten message * reduce line
mistercrunch
added
🏷️ bot
Several improvements to the SQL Lab UI
@williaster @graceguo-supercat @conglei