Fix broken cache_key #5681
Merged
Fix broken cache_key #5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5681 +/- ##
==========================================
- Coverage 63.51% 63.51% -0.01%
==========================================
Files 360 360
Lines 22904 22903 -1
Branches 2551 2551
==========================================
- Hits 14548 14547 -1
Misses 8341 8341
Partials 15 15
Continue to review full report at Codecov.
|
|
LGTM |
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
(cherry picked from commit fef39a7)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
(cherry picked from commit fef39a7)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
(cherry picked from commit fef39a7)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
(cherry picked from commit fef39a7)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
(cherry picked from commit fef39a7)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new time filter broke the cache key. This PR fixes it.
Tested with a dashboard, changing the time range in the filter box now correctly refreshes charts.