[bug] 'an error has ooccured' when saving datasource #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check_ownership was failing when Alpha user was saving a datasource from the datasource editor.
Codecov Report
@@ Coverage Diff @@
## master #5683 +/- ##
==========================================
+ Coverage 63.49% 63.49% +<.01%
==========================================
Files 360 360
Lines 22910 22912 +2
Branches 2551 2551
==========================================
+ Hits 14547 14549 +2
Misses 8348 8348
Partials 15 15
Continue to review full report at Codecov.
|
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
The check_ownership was failing when Alpha user was saving a datasource from the datasource editor.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check_ownership was failing when Alpha user was saving a datasource
from the datasource editor.