Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-5] Refactor force-directed graph #5691

Merged
merged 2 commits into from Aug 22, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 21, 2018

  • Extract slice and formData from visualization code.
  • Enable renderTrigger for props that are compatible.
  • Tested that it works like before.

@codecov-io
Copy link

codecov-io commented Aug 21, 2018

Codecov Report

Merging #5691 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5691      +/-   ##
==========================================
- Coverage   63.49%   63.48%   -0.02%     
==========================================
  Files         360      360              
  Lines       22934    22939       +5     
  Branches     2555     2555              
==========================================
  Hits        14562    14562              
- Misses       8357     8362       +5     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/explore/visTypes.jsx 57.14% <ø> (ø) ⬆️
superset/assets/src/explore/controls.jsx 45.92% <ø> (ø) ⬆️
...perset/assets/src/visualizations/directed_force.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e7778...7355dc4. Read the comment docs.

@mistercrunch mistercrunch merged commit 3929f0f into apache:master Aug 22, 2018
kristw added a commit to kristw/incubator-superset that referenced this pull request Aug 22, 2018
* Refactor and add props to Force Directed Graph

* update label and enable renderTrigger

(cherry picked from commit 3929f0f)
@kristw kristw deleted the kristw-force-directed branch August 22, 2018 18:14
@kristw kristw changed the title Refactor force-directed graph [SIP-5] Refactor force-directed graph Aug 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Refactor and add props to Force Directed Graph

* update label and enable renderTrigger
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants