Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-5] Refactor sunburst #5699

Merged
merged 4 commits into from
Aug 27, 2018
Merged

[SIP-5] Refactor sunburst #5699

merged 4 commits into from
Aug 27, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 22, 2018

  • Extract slice and formData according to [SIP-5]
  • Fix small issues and syntax inside sunburst.

@williaster @conglei

@codecov-io
Copy link

Codecov Report

Merging #5699 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5699      +/-   ##
==========================================
- Coverage   63.45%   63.44%   -0.01%     
==========================================
  Files         361      361              
  Lines       22972    22974       +2     
  Branches     2557     2557              
==========================================
  Hits        14576    14576              
- Misses       8381     8383       +2     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/visualizations/sunburst.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8992755...590a407. Read the comment docs.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristw kristw changed the title Refactor sunburst [SIP-5] Refactor sunburst Aug 24, 2018
@kristw
Copy link
Contributor Author

kristw commented Aug 27, 2018

Ready to merge

@williaster williaster merged commit 8d01c84 into apache:master Aug 27, 2018
kristw added a commit to kristw/incubator-superset that referenced this pull request Aug 27, 2018
* extract slice and formData

* fix small issues

* Update visual

* update css

(cherry picked from commit 8d01c84)
@kristw kristw deleted the kristw-sunburst branch August 27, 2018 20:35
kristw added a commit to kristw/incubator-superset that referenced this pull request Aug 27, 2018
* extract slice and formData

* fix small issues

* Update visual

* update css

(cherry picked from commit 8d01c84)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* extract slice and formData

* fix small issues

* Update visual

* update css
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* extract slice and formData

* fix small issues

* Update visual

* update css
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants