Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-5] Refactor and update heatmap #5704

Merged
merged 7 commits into from
Aug 28, 2018
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 22, 2018

  • Extract slice and formData according to [SIP-5]
  • Fix small issues and syntax inside heatmap.
  • Move legend to the right
  • Make axis labels align to the ticks

image

@williaster @conglei

@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #5704 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5704      +/-   ##
==========================================
- Coverage   63.45%   63.43%   -0.02%     
==========================================
  Files         361      361              
  Lines       22972    22978       +6     
  Branches     2557     2558       +1     
==========================================
  Hits        14576    14576              
- Misses       8381     8387       +6     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/visualizations/heatmap.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8992755...549433a. Read the comment docs.

@kristw kristw changed the title Refactor and update heatmap [SIP-5] Refactor and update heatmap Aug 24, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for going through all of these so thoroughly/carefully, and making big improvements on top of it!

@williaster williaster merged commit fcf2c75 into apache:master Aug 28, 2018
@kristw kristw deleted the kristw-heatmap branch August 28, 2018 17:10
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 5, 2018
* Extract slice and formData

* Define data shape

* update style

* organize imports

* fix heatmap axis labels

* add new line

* adjust indent

(cherry picked from commit fcf2c75)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Extract slice and formData

* Define data shape

* update style

* organize imports

* fix heatmap axis labels

* add new line

* adjust indent
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Extract slice and formData

* Define data shape

* update style

* organize imports

* fix heatmap axis labels

* add new line

* adjust indent
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants