Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geojson property names #5708

Merged

Conversation

joshbrooks
Copy link
Contributor

To be usable in maps, the field name for the ISO 3166 code must be 'ISO'. This PR relabels those field names which are incorrect for Myanmar and Timor-Leste.

@codecov-io
Copy link

Codecov Report

Merging #5708 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5708   +/-   ##
=======================================
  Coverage   63.45%   63.45%           
=======================================
  Files         361      361           
  Lines       22972    22972           
  Branches     2557     2557           
=======================================
  Hits        14576    14576           
  Misses       8381     8381           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8992755...e9af9bb. Read the comment docs.

@mistercrunch mistercrunch merged commit 5e6efae into apache:master Aug 23, 2018
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Aug 27, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Aug 27, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata

(cherry picked from commit 5e6efae)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Add geojson for Myanmar

* Adds 'myanmar.geojson' file

* Adds "iso-3166" codes

* Uppercase ISO fieldname in TL, MY geodata
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants