Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 403 on no authorization #5716

Merged
merged 2 commits into from Aug 24, 2018
Merged

Conversation

betodealmeida
Copy link
Member

When a user has no permission to access a table we should return a 403:

403 Forbidden The server understood the request, but is refusing to fulfill it. Authorization will not help and the request SHOULD NOT be repeated.

@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #5716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5716   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files         361      361           
  Lines       22977    22977           
  Branches     2558     2558           
=======================================
  Hits        14575    14575           
  Misses       8387     8387           
  Partials       15       15
Impacted Files Coverage Δ
superset/views/core.py 73.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6efae...c567a89. Read the comment docs.

@hughhhh hughhhh self-assigned this Aug 24, 2018
@hughhhh hughhhh self-requested a review August 24, 2018 16:00
@hughhhh hughhhh removed their assignment Aug 24, 2018
Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@betodealmeida betodealmeida merged commit 2abc941 into apache:master Aug 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
Return 403 on no authorization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants