[SIP-5] Refactor Paired t-test #5762
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5762 +/- ##
==========================================
- Coverage 63.7% 63.68% -0.02%
==========================================
Files 366 367 +1
Lines 23143 23150 +7
Branches 2599 2597 -2
==========================================
Hits 14744 14744
- Misses 8384 8391 +7
Partials 15 15
Continue to review full report at Codecov.
|
| @@ -1,5 +1,5 @@ | |||
| .paired_ttest .scrollbar-container { | |||
| overflow: scroll; | |||
| overflow: auto; | |||
There was a problem hiding this comment.
hide all the scroll bars! 🙌
| const propTypes = { | ||
| className: PropTypes.string, | ||
| metrics: PropTypes.arrayOf(PropTypes.string).isRequired, | ||
| groups: PropTypes.array.isRequired, |
There was a problem hiding this comment.
is this one also PropTypes.arrayOf(PropTypes.string).isRequired?
| import './paired_ttest.css'; | ||
| const propTypes = { | ||
| metric: PropTypes.string.isRequired, | ||
| groups: PropTypes.array.isRequired, |
There was a problem hiding this comment.
is this also PropTypes.arrayOf(PropTypes.string).isRequired?
| const propTypes = { | ||
| metric: PropTypes.string.isRequired, | ||
| groups: PropTypes.array.isRequired, | ||
| data: PropTypes.array.isRequired, |
There was a problem hiding this comment.
I can't quite tell what group is from the code, seems like an array based on this line
[ { group: [array of something?] values: [number, number] } ]
PropTypes.arrayOf(
PropTypes.shape({
group: PropTypes.arrayOf(??),
values: PropTypes.arrayOf(PropTypes.number),
}),
)| className: PropTypes.string, | ||
| metrics: PropTypes.arrayOf(PropTypes.string).isRequired, | ||
| groups: PropTypes.array.isRequired, | ||
| data: PropTypes.object.isRequired, |
There was a problem hiding this comment.
could we be more specific about the shape here? I can't quite figure out what group is from the code, seems like an array based on this line
{ my_metric: [ { group: [array of something?] values: [number, number] } ] }
PropTypes.objectOf(
PropTypes.arrayOf(
PropTypes.shape({
group: PropTypes.arrayOf(??),
values: PropTypes.arrayOf(PropTypes.number),
}),
),
)
|
Thanks you for catching the |
* extract TTestTable into another file. * Move into directory. * update proptypes (cherry picked from commit 68e7794)
* extract TTestTable into another file. * Move into directory. * update proptypes
* extract TTestTable into another file. * Move into directory. * update proptypes
mistercrunch
added
🏷️ bot
sliceandformDataTTestTablecomponent into another file.@williaster @conglei