Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] IS NOT NULL filter triggers KeyError: 'val' #5764

Merged
merged 1 commit into from
Aug 28, 2018
Merged

[bugfix] IS NOT NULL filter triggers KeyError: 'val' #5764

merged 1 commit into from
Aug 28, 2018

Conversation

mistercrunch
Copy link
Member 

Traceback (most recent call last):
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/models/core.py", line 1018, in wrapper
    value = f(*args, **kwargs)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
    return f(self, *args, **kwargs)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/views/core.py", line 1264, in explore
    utils.convert_legacy_filters_into_adhoc(form_data)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/utils.py", line 962, in convert_legacy_filters_into_adhoc
    fd['adhoc_filters'].append(to_adhoc(filt, 'SIMPLE', clause))
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/utils.py", line 726, in to_adhoc
    'comparator': filt['val'],
KeyError: 'val'

betodealmeida
betodealmeida approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We should at some point improve the metric component so that the value input is disabled when IS NULL and IS NOT NULL are selected.

@mistercrunch
Copy link
Member Author

+1 @hughhhh ^^^

@mistercrunch mistercrunch merged commit 6c6ea37 into apache:master Aug 28, 2018
@mistercrunch mistercrunch deleted the fix_null branch August 28, 2018 22:26
@betodealmeida
Copy link
Member

betodealmeida commented Aug 28, 2018 •
edited
Loading

@mistercrunch @hughhhh I have a PR fixing the UI for this, will send for review.

Edit: #5766

mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
895df8a 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
e954874 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
1d9ba6b 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
a266305 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
dd14197 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
d149df2 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
24331c5 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
1416da1 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
39c127f 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
2ac6976 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
4c80bdc 
(cherry picked from commit 6c6ea37)
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 9, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
0a9b395 
(cherry picked from commit 6c6ea37)
@graceguo-supercat graceguo-supercat mentioned this pull request Oct 9, 2018
Merged
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
22aa16a 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
b40c96d 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
c555929 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
afe1d02
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
2146868 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
a8aa3c8 
(cherry picked from commit 6c6ea37)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
79702e1 
(cherry picked from commit 6c6ea37)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
e0ba64b 
(cherry picked from commit 6c6ea37)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
cb867fb 
(cherry picked from commit 6c6ea37)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
f6ea7f4 
(cherry picked from commit 6c6ea37)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
4c748b4 
(cherry picked from commit 6c6ea37)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
55f5fd7 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
1ab5451 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
be0520a 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
aa28221 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
cb173b0 
(cherry picked from commit 6c6ea37)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
8d77903 
(cherry picked from commit 6c6ea37)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
1b76aa2 
(cherry picked from commit 6c6ea37)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
c4b40ce 
(cherry picked from commit 6c6ea37)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
[bugfix] IS NOT NULL filter triggers KeyError: 'val' (apache#5764)
2b254f2
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mistercrunch @betodealmeida