fix sqlparse bug and refactor #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
fix_sqlparse_aliases_bug_and_refactor
branch
4 times, most recently
from
f06f668
to
987b0b0
Compare
timifasubaa
force-pushed
the
fix_sqlparse_aliases_bug_and_refactor
branch
from
987b0b0
to
1e94215
Compare
timifasubaa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5768 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 364 364
Lines 23059 23059
Branches 2568 2568
=======================================
Hits 14717 14717
Misses 8327 8327
Partials 15 15
Continue to review full report at Codecov.
|
This was referenced Aug 29, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some edge cases in how we parse queries in sqlparse.