[explore] add "View samples" modal to action buttons #5770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5770 +/- ##
==========================================
+ Coverage 48.17% 48.17% +<.01%
==========================================
Files 393 393
Lines 23591 23626 +35
Branches 2630 2636 +6
==========================================
+ Hits 11365 11382 +17
- Misses 12226 12244 +18
Continue to review full report at Codecov.
|
mistercrunch
force-pushed
the
decouple_query_results
branch
from
985844d
to
09e00f5
Compare
|
@betodealmeida ping |
betodealmeida
approved these changes
Sep 14, 2018
| @@ -185,6 +185,17 @@ def get_fillna_for_columns(self, columns=None): | |||
| } | |||
| return fillna | |||
|
|
|||
| def get_samples(self): | |||
There was a problem hiding this comment.
Should we add a sort by random here? I guess it would be hard since it's database dependent...
There was a problem hiding this comment.
Yup that would be database dependent and could be very expensive...
Also broke down the `View query` and `View results` as different request so that viewing the query does not require fetching the results anymore
mistercrunch
force-pushed
the
decouple_query_results
branch
from
09e00f5
to
74df0fa
Compare
Closed
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* [explore] add "View samples" modal to action buttons Also broke down the `View query` and `View results` as different request so that viewing the query does not require fetching the results anymore * fix js tests * lint (cherry picked from commit 73d1e45)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* [explore] add "View samples" modal to action buttons Also broke down the `View query` and `View results` as different request so that viewing the query does not require fetching the results anymore * fix js tests * lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also broke down the
View queryandView resultsas differentrequest so that viewing the query does not require fetching the results
anymore.