Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Big Number Thumbnail #5782

Merged
merged 1 commit into from Aug 31, 2018
Merged

Update Big Number Thumbnail #5782

merged 1 commit into from Aug 31, 2018

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 30, 2018

Update big number thumbnail in selection panel

screen shot 2018-08-30 at 1 20 29 pm

@kristw @williaster

@codecov-io
Copy link

Codecov Report

Merging #5782 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5782   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         364      364           
  Lines       23099    23099           
  Branches     2572     2572           
=======================================
  Hits        14729    14729           
  Misses       8355     8355           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2b502...35eda2e. Read the comment docs.

@kristw
Copy link
Contributor

kristw commented Aug 30, 2018

Nice. Could you also update big_number_total?

@hughhhh
Copy link
Member Author

hughhhh commented Aug 31, 2018

@kristw I'll handle that in another PR lowkey having issues with my dev environment at the moment

@hughhhh hughhhh merged commit e12f4fb into master Aug 31, 2018
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 11, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
(cherry picked from commit e12f4fb)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit e12f4fb)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit e12f4fb)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit e12f4fb)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit e12f4fb)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit e12f4fb)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit e12f4fb)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit e12f4fb)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
(cherry picked from commit e12f4fb)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
(cherry picked from commit e12f4fb)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@kristw kristw deleted the update-big-viz-thumbnail branch March 6, 2019 16:46
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants