[celery] setting default #5812
Merged
[celery] setting default #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5812 +/- ##
==========================================
+ Coverage 63.82% 63.83% +<.01%
==========================================
Files 364 364
Lines 23099 23100 +1
Branches 2587 2587
==========================================
+ Hits 14744 14745 +1
Misses 8340 8340
Partials 15 15
Continue to review full report at Codecov.
|
timifasubaa
approved these changes
Sep 4, 2018
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Sep 6, 2018
(cherry picked from commit cf12ea0)
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 6, 2018
[celery] setting default (apache#5812)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remedies an issue we've been seeing with
celery_statsdwherecelery.current_apprefers to the default rather than the app instance. Per this thread it seems like enforcing the app to be the default for all threads remedies the issue, which I verified via testing locally.to: @michellethomas @mistercrunch @timifasubaa