Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix bignumber overflow in dashboard #5839

Merged
merged 3 commits into from
Sep 7, 2018
Merged

[bugfix] Fix bignumber overflow in dashboard #5839

merged 3 commits into from
Sep 7, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 7, 2018 •
edited
Loading

  • The key fix is in ChartHolder.jsx
  • Other changes are (1) moving files into folder and (2) be a bit more conservative about width given the container's width, which may be not round number.

Before
pasted_image_9_6_18__5_19_pm

After
pasted_image_9_6_18__5_49_pm

@john-bodley

@john-bodley john-bodley merged commit 3f8b970 into apache:master Sep 7, 2018
@kristw kristw deleted the kristw-fix-bignumber branch September 11, 2018 05:21
@kristw kristw mentioned this pull request Sep 12, 2018
Merged
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 12, 2018
@kristw
[bugfix] Fix bignumber overflow in dashboard (apache#5839)
436b221 
* Move BigNumber to directory.

* fix chart margin in dashboard

* Fix margin and be more conservative about width.

(cherry picked from commit 3f8b970)
@kristw kristw mentioned this pull request Sep 12, 2018
Merged
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@kristw @betodealmeida
[bugfix] Fix bignumber overflow in dashboard (apache#5839)
019409a 
* Move BigNumber to directory.

* fix chart margin in dashboard

* Fix margin and be more conservative about width.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@kristw @john-bodley
[bugfix] Fix bignumber overflow in dashboard (apache#5839)
9e91070 
* Move BigNumber to directory.

* fix chart margin in dashboard

* Fix margin and be more conservative about width.
@laxmanraparthi laxmanraparthi mentioned this pull request Oct 28, 2023
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kristw @john-bodley @mistercrunch