[bugfix] mapbox pan on filter #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default
…ry for computing the viewport now that it is driven by the bounds from the backend.
kristw
approved these changes
Sep 11, 2018
| @@ -9,9 +9,6 @@ export const LUMINANCE_RED_WEIGHT = 0.2126; | |||
| export const LUMINANCE_GREEN_WEIGHT = 0.7152; | |||
| export const LUMINANCE_BLUE_WEIGHT = 0.0722; | |||
| export const MILES_PER_KM = 1.60934; | |||
| export const DEFAULT_LONGITUDE = -122.405293; | |||
| @@ -6,12 +6,6 @@ import Immutable from 'immutable'; | |||
| import supercluster from 'supercluster'; | |||
| import ViewportMercator from 'viewport-mercator-project'; | |||
| import ScatterPlotGlowOverlay from './ScatterPlotGlowOverlay'; | |||
|
|
|||
| import { | |||
mistercrunch
requested changes
Sep 11, 2018
mistercrunch
approved these changes
Sep 11, 2018
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 18, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch @betodealmeida @youngyjd