Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] FilterBox crashes after React 16 update #5860

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 11, 2018

Fix Object.assign try to write to read-only option.style

@graceguo-supercat

@kristw kristw changed the title [bugfix] FilterBox crashes after react 16 update [bugfix] FilterBox Crashes after react 16 update Sep 11, 2018
@kristw kristw changed the title [bugfix] FilterBox Crashes after react 16 update [bugfix] FilterBox crashes after React 16 update Sep 11, 2018
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #5860 into master will decrease coverage by 14.25%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5860       +/-   ##
===========================================
- Coverage   77.99%   63.73%   -14.26%     
===========================================
  Files          46      374      +328     
  Lines        9312    23325    +14013     
  Branches        0     2607     +2607     
===========================================
+ Hits         7263    14867     +7604     
- Misses       2049     8445     +6396     
- Partials        0       13       +13
Impacted Files Coverage Δ
.../assets/src/components/VirtualizedRendererWrap.jsx 100% <100%> (ø)
...sets/src/explore/components/ExploreChartHeader.jsx 71.42% <0%> (ø)
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...perset/assets/src/dashboard/util/getEmptyLayout.js 0% <0%> (ø)
...ts/src/dashboard/util/getComponentWidthFromDrop.js 96.15% <0%> (ø)
...erset/assets/src/SqlLab/components/QuerySearch.jsx 69.36% <0%> (ø)
...rc/explore/components/controls/AnnotationLayer.jsx 22.92% <0%> (ø)
superset/assets/src/welcome/DashboardTable.jsx 81.81% <0%> (ø)
...erset/assets/src/dashboard/util/injectCustomCss.js 91.66% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 97.91% <0%> (ø)
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df720d...1617dfb. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 962eb08 into apache:master Sep 11, 2018
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 12, 2018
@kristw kristw deleted the kristw-fix-filter-react16 branch September 18, 2018 01:02
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants