fix sqllab logging #5862
Merged
fix sqllab logging #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
fix_sqllab_logging
branch
from
f4a0b85
to
6033c5a
Compare
timifasubaa
force-pushed
the
fix_sqllab_logging
branch
from
6033c5a
to
9ead09f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5862 +/- ##
==========================================
+ Coverage 63.69% 63.73% +0.04%
==========================================
Files 374 374
Lines 23325 23325
Branches 2607 2607
==========================================
+ Hits 14857 14867 +10
+ Misses 8455 8445 -10
Partials 13 13
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Sep 12, 2018
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 13, 2018
(cherry picked from commit c82cea3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a case in sqllab celery worker where run query is called in the asynchronous case but not with the query. (It ensures there is a start_time specified before subtracting)
It also fixes a minor bug where I flipped the operands beside the minus sign
@john-bodley