Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[time table] fix sorting on missing values #5863

Merged
merged 1 commit into from Sep 12, 2018
Merged

[time table] fix sorting on missing values #5863

merged 1 commit into from Sep 12, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Sep 11, 2018 •
edited

Empty cells would show as 0 and sort randomly.

@codecov-io
Copy link

codecov-io commented Sep 12, 2018 •
edited

Codecov Report

Merging #5863 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5863      +/-   ##
==========================================
+ Coverage   63.69%   63.73%   +0.04%     
==========================================
  Files         374      374              
  Lines       23325    23326       +1     
  Branches     2607     2608       +1     
==========================================
+ Hits        14857    14867      +10     
+ Misses       8455     8446       -9     
  Partials       13       13
Impacted Files Coverage Δ
superset/assets/src/visualizations/time_table.jsx 0% <0%> (ø) ⬆️
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.19% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01212c3...741d7d8. Read the comment docs.

@betodealmeida betodealmeida merged commit 367dcda into apache:master Sep 12, 2018
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 12, 2018
@mistercrunch @kristw
[time table] fix sorting on missing values (apache#5863)
e108110 
(cherry picked from commit 367dcda)
@kristw kristw mentioned this pull request Sep 12, 2018
Merged
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[time table] fix sorting on missing values (apache#5863)
b37c458 
(cherry picked from commit 367dcda)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[time table] fix sorting on missing values (apache#5863)
9aa4337 
(cherry picked from commit 367dcda)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[time table] fix sorting on missing values (apache#5863)
a1a808c 
(cherry picked from commit 367dcda)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[time table] fix sorting on missing values (apache#5863)
fb5e666 
(cherry picked from commit 367dcda)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[time table] fix sorting on missing values (apache#5863)
f350402 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
8bdb9ea 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
d47a7d8
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
d480689 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
e05a57f 
(cherry picked from commit 367dcda)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[time table] fix sorting on missing values (apache#5863)
cb60ac1 
(cherry picked from commit 367dcda)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[time table] fix sorting on missing values (apache#5863)
48f44e9 
(cherry picked from commit 367dcda)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[time table] fix sorting on missing values (apache#5863)
2d44e6b 
(cherry picked from commit 367dcda)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[time table] fix sorting on missing values (apache#5863)
338d168 
(cherry picked from commit 367dcda)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
@mistercrunch
[time table] fix sorting on missing values (apache#5863)
52c0b51 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
0ad1840 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
a860295 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
1aafd42 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
e70a5d1 
(cherry picked from commit 367dcda)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
888cfd9 
(cherry picked from commit 367dcda)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[time table] fix sorting on missing values (apache#5863)
baa6398 
(cherry picked from commit 367dcda)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[time table] fix sorting on missing values (apache#5863)
73a8ce0 
(cherry picked from commit 367dcda)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch @betodealmeida
[time table] fix sorting on missing values (apache#5863)
e8a7379
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mistercrunch @codecov-io @betodealmeida