[bug fix] Fixed adhoc metric is not working for WordCloud #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing. Do you mind making another small tweak to make "flat" the default |
kristw
approved these changes
Sep 12, 2018
|
@kristw I agree |
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* fixed adhoc metric * change rotate default to flat (cherry picked from commit 8569261)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* fixed adhoc metric * change rotate default to flat
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5857
This PR is to fix the issue that adhoc metrics don't work for wordcloud. The root cause is the inconsistent metric formats between normal metrics and adhoc metrics. @villebro
The inconsistency is pretty annoying, and we should, imo, make it consistent in a long term when refactoring the formdata part.
@john-bodley @williaster @mistercrunch @kristw