[bugfix] Fix color scheme picker #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
reviewed
Sep 17, 2018
| this.props.schemes[defaultProps.value]; | ||
| const { schemes } = this.props; | ||
| const schemeLookup = _.isFunction(schemes) ? schemes() : schemes; | ||
| const currentScheme = schemeLookup[key.value || defaultProps]; |
There was a problem hiding this comment.
should this be defaultProps.value?
williaster
approved these changes
Sep 17, 2018
|
Nice catch. Thanks @williaster . |
kristw
force-pushed
the
kristw-color-picker
branch
from
78e8da5
to
707a710
Compare
kristw
force-pushed
the
kristw-color-picker
branch
from
707a710
to
368ec7c
Compare
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Fix color scheme picker * fix .value
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support dynamic choices by passing function instead of value to fix #5889
This will ensure that the
ColorSchemeControlwill always get the latest schemes registered toColorSchemeManager@mistercrunch @williaster @graceguo-supercat