Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sqllab querysearch typeahead permission issue #5906

Merged

Conversation

youngyjd
Copy link
Contributor

@youngyjd youngyjd commented Sep 15, 2018

Query search for users only has type ahead for admin role but not alpha role or sql_lab role. This is a permission issue because /users/api/read endpoint is not open to sql_lab users.

            <AsyncSelect
              dataEndpoint="/users/api/read"
              mutator={this.userMutator}
              value={this.state.userId}
              onChange={this.changeUser}
            />

Adding the specific permission to sql_lab role should fix the bug.

@youngyjd
Copy link
Contributor Author

@mistercrunch @betodealmeida @hughhhh a quick fix for query search permission issue.

@betodealmeida
Copy link
Member

Awesome, thanks for fixing this!

@betodealmeida betodealmeida merged commit 4c62494 into apache:master Sep 21, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
youngyjd added a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
youngyjd added a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
youngyjd added a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
youngyjd added a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
youngyjd added a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
youngyjd added a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants