Remove jquery usage to highlight sql lab menu #5907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset/assets/src/SqlLab/App.jsx
Outdated
| // Highlight the navbar menu | ||
| const menus = document.querySelectorAll('.nav.navbar-nav li.dropdown'); | ||
| const sqlLabMenu = Array.prototype.slice.apply(menus) | ||
| .filter(element => element.innerText.trim() === 'SQL Lab')[0]; |
There was a problem hiding this comment.
[].filter(cb)[0] is equivalent to [].find(cb)?
also if your filter function returns [], get its [0] will make trouble.
There was a problem hiding this comment.
Thank you. Will update.
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 18, 2018
* Remove jquery hack * change filter to find (cherry picked from commit 39ef77a)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Remove jquery hack * change filter to find
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove jquery usage to highlight sql lab menu
@graceguo-supercat