Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contributing.md] swap cypress command order #5921

Merged
merged 1 commit into from Sep 18, 2018

Conversation

williaster
Copy link
Contributor

@williaster williaster commented Sep 18, 2018

@michellethomas running the commands in the previous order failed for me, but worked after first running db upgrade (this seems to mirror other parts of the contributing.md + cypress_build.sh files as well)

@michellethomas
Copy link
Contributor

oh thanks, I was just about to do this 👍

@codecov-io
Copy link

Codecov Report

Merging #5921 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5921      +/-   ##
=========================================
+ Coverage   63.66%   63.7%   +0.04%     
=========================================
  Files         386     386              
  Lines       23538   23538              
  Branches     2628    2628              
=========================================
+ Hits        14986   14996      +10     
+ Misses       8539    8529      -10     
  Partials       13      13
Impacted Files Coverage Δ
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.45% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a3319...c154d49. Read the comment docs.

@williaster williaster merged commit 42ab175 into master Sep 18, 2018
@williaster williaster deleted the williaster--contributing-cypress branch September 18, 2018 21:37
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants