Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding configuration to cypress to enable dashboard #5926

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Adding configuration to cypress to enable dashboard #5926

merged 1 commit into from
Sep 20, 2018

Conversation

michellethomas
Copy link
Contributor

Adding a project id to enable cypress dashboard to work with superset.

@john-bodley

@michellethomas michellethomas force-pushed the adding_cypress_dashboard_to_superset branch from 6c1552a to 1db6042 Compare September 19, 2018 00:58
@michellethomas michellethomas force-pushed the adding_cypress_dashboard_to_superset branch from 1db6042 to 09c0f2a Compare September 19, 2018 01:17
@codecov-io
Copy link

Codecov Report

Merging #5926 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5926      +/-   ##
==========================================
+ Coverage   63.67%   63.72%   +0.05%     
==========================================
  Files         386      386              
  Lines       23537    23537              
  Branches     2621     2621              
==========================================
+ Hits        14987    15000      +13     
+ Misses       8537     8524      -13     
  Partials       13       13
Impacted Files Coverage Δ
superset/views/core.py 74.22% <0%> (+0.22%) ⬆️
superset/models/core.py 85.09% <0%> (+0.33%) ⬆️
superset/db_engine_specs.py 55.45% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325e7c0...09c0f2a. Read the comment docs.

2 similar comments
@codecov-io
Copy link

Codecov Report

Merging #5926 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5926      +/-   ##
==========================================
+ Coverage   63.67%   63.72%   +0.05%     
==========================================
  Files         386      386              
  Lines       23537    23537              
  Branches     2621     2621              
==========================================
+ Hits        14987    15000      +13     
+ Misses       8537     8524      -13     
  Partials       13       13
Impacted Files Coverage Δ
superset/views/core.py 74.22% <0%> (+0.22%) ⬆️
superset/models/core.py 85.09% <0%> (+0.33%) ⬆️
superset/db_engine_specs.py 55.45% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325e7c0...09c0f2a. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #5926 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5926      +/-   ##
==========================================
+ Coverage   63.67%   63.72%   +0.05%     
==========================================
  Files         386      386              
  Lines       23537    23537              
  Branches     2621     2621              
==========================================
+ Hits        14987    15000      +13     
+ Misses       8537     8524      -13     
  Partials       13       13
Impacted Files Coverage Δ
superset/views/core.py 74.22% <0%> (+0.22%) ⬆️
superset/models/core.py 85.09% <0%> (+0.33%) ⬆️
superset/db_engine_specs.py 55.45% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325e7c0...09c0f2a. Read the comment docs.

kristw
kristw reviewed Sep 19, 2018
View reviewed changes
superset/assets/cypress_build.sh
@@ -12,5 +12,5 @@ cd "$(dirname "$0")"
npm install -g yarn
yarn
npm run build
npm run cypress run
npm run cypress run --record --parallel --key 1f958c86-be14-44d9-8d08-fad68da06811
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is --record for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--record is used for setting up cypress with Dashboard https://dashboard.cypress.io/#/projects/fbf96q/runs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.. I see. Thought the name was abt video recording or sth.

@graceguo-supercat graceguo-supercat merged commit 15b1037 into apache:master Sep 20, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@michellethomas @betodealmeida
Adding configuration to cypress to enable dashboard (apache#5926)
2f1f9e5
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristw kristw kristw left review comments

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@michellethomas @codecov-io @kristw @john-bodley @mistercrunch @graceguo-supercat