Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cypress] wait and verify slice in dashboard one-by-one #5995

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 27, 2018

Try to fix the flaky cypress dashboard test, as discussed offline with @graceguo-supercat

@michellethomas

@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #5995 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5995   +/-   ##
=======================================
  Coverage   63.54%   63.54%           
=======================================
  Files         393      393           
  Lines       23654    23654           
  Branches     2638     2638           
=======================================
  Hits        15032    15032           
  Misses       8609     8609           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9a102...b26ecd5. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit 4868c00 into apache:master Sep 27, 2018
@kristw kristw deleted the kristw-cy-dash branch September 27, 2018 21:47
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants