[SIP-6] Migrate visualizations to new directory structure (part 2) #5997
Conversation
kristw
force-pushed
the
kristw-vis-dir2
branch
from
c03cdc7
to
f16cb80
Compare
Codecov Report
@@ Coverage Diff @@
## master #5997 +/- ##
==========================================
- Coverage 64.66% 64.65% -0.02%
==========================================
Files 448 454 +6
Lines 23773 23793 +20
Branches 2639 2641 +2
==========================================
+ Hits 15373 15383 +10
- Misses 8387 8397 +10
Partials 13 13
Continue to review full report at Codecov.
|
| min: Infinity, | ||
| max: -Infinity, | ||
| }); | ||
| opts.map = prop => ({ |
There was a problem hiding this comment.
wow this is an interesting api
| bigNumber, | ||
| className, | ||
| formatBigNumber: formatValue, | ||
| gradientId: `big_number_${containerId}`, |
There was a problem hiding this comment.
in a world where everything is react, we won't have ids like this right? I wonder if instead of exposing the container id and creating a gradient id based on it, whether we can just create a unique id using the shortid package we use elsewhere. I guess ideally it doesn't change every render 🤔
There was a problem hiding this comment.
Interesting idea. I like it. Can create the id in the constructor so it will not change every render.
kristw
force-pushed
the
kristw-vis-dir2
branch
2 times, most recently
from
fa165b0
to
d7c5a40
Compare
kristw
force-pushed
the
kristw-vis-dir2
branch
from
d7c5a40
to
46ff2c5
Compare
…pache#5997) * migrate MapBox * migrate bignumber * migrate timeseries table * migrate EventFlow * add default null * fix linting * use shortid instead of passing containerId
mistercrunch
added
🏷️ bot
Included in this PR
BigNumber
MapBox
TimeTable
EventFlow
Remaining for next PR
nvd3
iframe
markup
deck.gl
@conglei @williaster