Make NULL value grouping keys show up properly in rich tooltip #6003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6003 +/- ##
======================================
Coverage 73.5% 73.5%
======================================
Files 72 72
Lines 10001 10001
======================================
Hits 7351 7351
Misses 2650 2650Continue to review full report at Codecov.
|
hmanuel
force-pushed
the
hmanuel/null_tooltip
branch
from
0b60d1e
to
dad3e89
Compare
mistercrunch
reviewed
Oct 1, 2018
hmanuel
force-pushed
the
hmanuel/null_tooltip
branch
from
9b241a7
to
c730500
Compare
|
all relevant tests pass. master is failing, which is causing mine to fail |
|
@williaster @betodealmeida @graceguo-supercat Can we please get a commit for this small change from Twitter? :-) |
|
@mistercrunch can we please get a commit on this small change? from twitter |
williaster
requested changes
Nov 20, 2018
kristw
added
enhancement:request
hmanuel
force-pushed
the
hmanuel/null_tooltip
branch
from
0f0b2b4
to
0d6d457
Compare
|
@williaster I made the requested changes, please take a look |
williaster
approved these changes
Jan 8, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was a NULL value grouping key, it would show up in the legend as but would show in the rich tooltip as an empty string. I added an if statement so that the NULL value will show up as in the rich tooltip, as it appears in the legend.
Before:
After:
