Sorting tables by "modified" is broken #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6027 +/- ##
==========================================
+ Coverage 64.6% 65.77% +1.16%
==========================================
Files 446 446
Lines 23814 25109 +1295
Branches 2639 2639
==========================================
+ Hits 15386 16515 +1129
- Misses 8415 8581 +166
Partials 13 13
Continue to review full report at Codecov.
|
|
👍 |
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Fix sorting by modified * Fix column name in decorator
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Fix sorting by modified * Fix column name in decorator (cherry picked from commit df341ff)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decorator should point to the column name (
changed_on).Currently:
With this fix:
Works both for ascending and descending sorting.