Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix margin issue in dashboard modal #6037

Merged

Conversation

graceguo-supercat
Copy link

This bug was introduced by #5771. The extra margin also makes cursor in CSS Editor mis-aligned.

screen shot 2018-10-04 at 3 33 03 pm

screen shot 2018-10-04 at 3 35 55 pm

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #6037 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6037     +/-   ##
=========================================
+ Coverage   77.79%   77.89%   +0.1%     
=========================================
  Files          46       46             
  Lines        9398     9398             
=========================================
+ Hits         7311     7321     +10     
+ Misses       2087     2077     -10
Impacted Files Coverage Δ
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c701c...64042c4. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 361f588 into apache:master Oct 9, 2018
@graceguo-supercat graceguo-supercat deleted the gg-DashboardCSSEditor branch October 9, 2018 05:48
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 9, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants